Add slice function #250
Add slice function #250
Conversation
|
In terms of LOC this is + 15 lines
- 35 lines:D |
|
Thanks @megawac! Sorry for taking so long. I have a few minor comments. |
|
|
||
| Stream.prototype.take = function (n) { | ||
| if (n === 0) { | ||
| if (start < 0 || start >= end) { |
There was a problem hiding this comment.
start < 0 should be treated as start === 0. Like how drop handles n < 0. Otherwise, slice(-1, Infinity) and drop(-1) won't the the same.
Also, add a
if (start === 0 && end === Infinity) {
return this;
}so that we can drop the if (n <= 0) check in drop.
There was a problem hiding this comment.
What is Misreaddrop(-1) supposed to do because this probably breaks it (there are no unit tests for drop or take with negative indices)
| */ | ||
|
|
||
| Stream.prototype.take = function (n) { | ||
| var s = this.slice(0, n); | ||
| s.id = 'take:' + s.id; |
There was a problem hiding this comment.
Is this stuff important?
There was a problem hiding this comment.
The s.id? No. It's mostly for debugging. No harm in leaving it though.
|
Thanks. This looks good to me. There's some talk of maybe changing the name of this transform to |
|
We should probably stick with |
|
Sounds good. |
This pretty much unifies the
dropandtakefunctions while adding a potentially useful function :)